fix: workaround for os module using wrong path separator when cross compiling#62
Merged
richard-ramos merged 1 commit intomainfrom Feb 16, 2026
Merged
fix: workaround for os module using wrong path separator when cross compiling#62richard-ramos merged 1 commit intomainfrom
richard-ramos merged 1 commit intomainfrom
Conversation
richard-ramos
requested review from
Copilot,
gmelodie and
vladopajic
and removed request for
a team
richard-ramos
force-pushed
the
static-read-fix
branch
from
3713e95 to
63114af
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to fix cross-compilation issues where Nim’s os path handling uses the target platform’s path separator, causing build-time file access problems (notably around Windows ASM handling).
Changes:
- Adjusts how the MD5 hash for cached NASM object rebuilds is computed in the Windows ASM build step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
richard-ramos
force-pushed
the
static-read-fix
branch
from
63114af to
656f781
Compare
vladopajic
approved these changes
Feb 13, 2026
richard-ramos
force-pushed
the
static-read-fix
branch
from
656f781 to
723fd05
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tersec
approved these changes
Feb 13, 2026
richard-ramos
force-pushed
the
static-read-fix
branch
from
723fd05 to
7b3059d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc: @tersec